zml1206 commented on code in PR #7543:
URL: https://github.com/apache/incubator-gluten/pull/7543#discussion_r1804307776
##########
backends-velox/src/main/scala/org/apache/gluten/extension/HLLRewriteRule.scala:
##########
@@ -25,37 +25,34 @@ import org.apache.spark.sql.catalyst.expressions.Literal
import
org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression,
HyperLogLogPlusPlus}
import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, LogicalPlan}
import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.catalyst.trees.TreePattern.AGGREGATE_EXPRESSION
import org.apache.spark.sql.types._
case class HLLRewriteRule(spark: SparkSession) extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan =
LogicalPlanSelector.maybe(spark, plan) {
- plan.resolveOperatorsUp {
+ plan.transformUp {
Review Comment:
In more detail, as I understand, use `resolveOperatorsUp` here may cause
errors. `resolveOperatorsUp` is similar to `transformUp`, but it will not
process nodes which _analyzed is true. @PHILO-HE
In addition, the same problem exists in `CHAggregateFunctionRewriteRule`.
@beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
