PHILO-HE commented on code in PR #7543:
URL: https://github.com/apache/incubator-gluten/pull/7543#discussion_r1804341105
##########
backends-velox/src/main/scala/org/apache/gluten/extension/HLLRewriteRule.scala:
##########
@@ -25,37 +25,34 @@ import org.apache.spark.sql.catalyst.expressions.Literal
import
org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression,
HyperLogLogPlusPlus}
import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, LogicalPlan}
import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.catalyst.trees.TreePattern.AGGREGATE_EXPRESSION
import org.apache.spark.sql.types._
case class HLLRewriteRule(spark: SparkSession) extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan =
LogicalPlanSelector.maybe(spark, plan) {
- plan.resolveOperatorsUp {
+ plan.transformUp {
Review Comment:
@zml1206, thanks for your explanation!
cc @taiyang-li, could you fix it for `CHAggregateFunctionRewriteRule` in a
separate pr if you think necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
