wForget commented on PR #7573: URL: https://github.com/apache/incubator-gluten/pull/7573#issuecomment-2419033252
> My intuition is when an iterator was closed, it should not be called through `hasNext()` or `next()`. Perhaps there is a root cause of #7572 waiting us to find out. > > Instead of the PR's change, I think we can add a sanity check in `hasNext0` and `next0` to check if the iterator is closed. If it's closed, we throw an error indicating it's an illegal state. > > And we can then continue looking for a more proper solution for #7572. Actually the bug mentioned in #7572 has been fixed by #6698, and this PR aims to avoid similar problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
