zhztheplayer commented on code in PR #7573:
URL: https://github.com/apache/incubator-gluten/pull/7573#discussion_r1805721108
##########
gluten-arrow/src/main/java/org/apache/gluten/vectorized/ColumnarBatchOutIterator.java:
##########
@@ -54,6 +54,9 @@ public long itrHandle() {
@Override
public boolean hasNext0() throws IOException {
+ if (closed.get()) {
+ return false;
+ }
Review Comment:
Not meant to be nitpicking, but I think this is not needed for now?
`hasNext() == false` literally means the iterator was drained internally
while `closed == true` could mean the iterator was closed by a caller. The two
are semantically different so I think we can add this kind of logic when it's
really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
