zhztheplayer commented on issue #7605: URL: https://github.com/apache/incubator-gluten/issues/7605#issuecomment-2425689065
> > > When `spark.gluten.memory.dynamic.offHeap.sizing.enabled=true` it will not consider the configured off-heap size https://github.com/apache/incubator-gluten/blob/main/gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala#L167 > > > > > > Perhaps there was a tiny typo leading to a bug when PR #5439 was iterated? cc @supermem613 Would you like to help confirm? Thanks. > > A commit that looks like to be related in PR #5439 [8c7cfa5](https://github.com/apache/incubator-gluten/commit/8c7cfa59bf9f8c015e16c225d3d14c7801a977dd) > > @zhztheplayer what typo do you mean? Found this line https://github.com/apache/incubator-gluten/commit/8c7cfa59bf9f8c015e16c225d3d14c7801a977dd#diff-b6234f870afb82ba142a4f4e3e358ddb30dc4d5f00b3b9f5b4e9afddc9b4a761R31 `GlutenConfig.getConf().onHeapMemorySize()` was changed to `GlutenConfig.getConf().offHeapMemorySize()`, which doesn't look like intentional to me, but I am not sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
