zhztheplayer commented on issue #7605:
URL: 
https://github.com/apache/incubator-gluten/issues/7605#issuecomment-2425721316

   > `GlutenConfig.getConf().onHeapMemorySize()` was changed to 
`GlutenConfig.getConf().offHeapMemorySize()`, which doesn't look like 
intentional to me, but I am not sure.
   
   After reading more code I guess this was intentional... The code tended to 
set an off-heap size then use the size to cover off-heap + on-heap. The PR used 
on-heap initially at the time when I was reviewing.
   
   @wenwj0
   
   > As we can see above, the used off-heap memory is only 406847480(388MiB), 
while my off-heap configuration is 2.2GiB.
   
   I believe your case is because on-heap occupies the remaining 2.2 GiB - 388 
MiB, which could be considered by-design of the feature. But it would be great 
if you can share more background information about your use case. From my 
impression only a few users are using the option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to