Zand100 commented on issue #7750: URL: https://github.com/apache/incubator-gluten/issues/7750#issuecomment-2466971785
Hi, how should I handle constructing a `ColumnarBuildSideRelation` for the `HashedRelationBroadcastMode` case? ``` val fromBroadcast = from.asInstanceOf[Broadcast[HashedRelation]] val fromRelation = fromBroadcast.value.asReadOnlyCopy() ``` https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/spark/sql/execution/BroadcastUtils.scala#L97 If `fromBroadcast` is already an `UnsafeHashedRelation`, then it's already using a `BytesToBytesMap`, which is perfect. But if `fromBroadcast` is `LongHashedRelation` or `GeneralHashedRelation `, then should I convert it to `UnsafeHashedRelation`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
