Zand100 commented on issue #7750: URL: https://github.com/apache/incubator-gluten/issues/7750#issuecomment-2475237284
Could you please review https://github.com/apache/incubator-gluten/pull/7944 ? Should `ColumnarBuildSideRelation` still use the object handle (for example https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarBuildSideRelation.scala#L67) and construct the `ColumnarBatch` (I think that becomes on-heap again)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
