liuchunhua commented on issue #7932: URL: https://github.com/apache/incubator-gluten/issues/7932#issuecomment-2480896736
thanks @rui-mo the issue was not be fixed by picking https://github.com/facebookincubator/velox/commit/da39954c22f1dda1d4b78dae078fb1307fc2508f the reason of the error was the incorret handing of INT96 in https://github.com/oap-project/velox/blob/88856e6b139c761e7876b1cd3b29e8dad236d8c7/velox/dwio/common/DirectDecoder.h#L92-L105, the "numBytes" of decimal(27,2) is same as timestamp. I fixed the issue by this code ``` c++ if ((super::numBytes == 12) && (std::is_same_v<typename Visitor::FilterType, velox::common::TimestampRange>)/* INT96 */) { ``` ``` // add log I20241117 10:26:43.812453 75535 PageReader.cpp:55] page type: DATA_PAGE I20241117 10:26:43.812553 75535 PageReader.cpp:648] encoding: PLAIN page type: FIXED_LEN_BYTE_ARRAY I20241117 10:26:43.812584 75535 IntDecoder.h:440] userVInts:0bigEndian: 1numBytes:12 I20241117 10:26:43.812595 75535 IntDecoder.h:359] sizeof : 16 I20241117 10:26:43.812602 75535 IntDecoder.h:382] numBytes: 12 +-------+------------+------------+---------------+--------------------+--------------------+--------------------+--------------------+ |amt_int| amt_bigint|amt_decimal8| amt_decimal16| amt_decimal24| amt_decimal27| amt_decimal32| amt_decimal38| +-------+------------+------------+---------------+--------------------+--------------------+--------------------+--------------------+ | 2322|223243243224| 2343.33|343423423333.12|32423432432432324...|32423432432432324...|32423432432432324...|32423432432432324...| +-------+------------+------------+---------------+--------------------+--------------------+--------------------+--------------------+ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
