rui-mo commented on issue #7932: URL: https://github.com/apache/incubator-gluten/issues/7932#issuecomment-2481778384
> the issue was not be fixed by picking [facebookincubator/velox@da39954](https://github.com/facebookincubator/velox/commit/da39954c22f1dda1d4b78dae078fb1307fc2508f) > > the reason of the error was the incorret handing of INT96 in https://github.com/oap-project/velox/blob/88856e6b139c761e7876b1cd3b29e8dad236d8c7/velox/dwio/common/DirectDecoder.h#L92-L105, the "numBytes" of decimal(27,2) is same as timestamp. @liuchunhua Please note that the commit https://github.com/oap-project/velox/commit/07e7fd73c2eeaf9d4b25853ed8fca2d626b0675e you mentioned above is out-of-date in the latest code. As you mentioned, the reason for the incorrect result is `the "numBytes" of decimal(27,2) is same as timestamp`, while in the new code the timestamp decoding is moved out from DirectDecoder, so the decoding of INT96 should work for both timestamp and decimal(27, 2). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
