zhztheplayer commented on code in PR #7972: URL: https://github.com/apache/incubator-gluten/pull/7972#discussion_r1847894321
########## gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/heuristic/ExpandFallbackPolicy.scala: ########## @@ -31,40 +33,33 @@ import org.apache.spark.sql.execution.exchange.Exchange // spotless:off /** - * Note, this rule should only fallback to row-based plan if there is no harm. - * The follow case should be handled carefully + * Note, this rule should only fallback to row-based plan if there is no harm. The follow case + * should be handled carefully * - * 1. A BHJ and the previous broadcast exchange is columnar - * We should still make the BHJ columnar, otherwise it will fail if - * the vanilla BHJ accept a columnar broadcast exchange, e.g., + * 1. A BHJ and the previous broadcast exchange is columnar We should still make the BHJ columnar, + * otherwise it will fail if the vanilla BHJ accept a columnar broadcast exchange, e.g., * - * Scan Scan - * \ | - * \ Columnar Broadcast Exchange - * \ / - * BHJ - * | - * VeloxColumnarToRow - * | - * Project (unsupport columnar) + * Scan Scan \ | \ Columnar Broadcast Exchange \ / BHJ + * \| VeloxColumnarToRow + * \| Project (unsupport columnar) Review Comment: Malformed by IDE linter, will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
