zhztheplayer commented on PR #8133: URL: https://github.com/apache/incubator-gluten/pull/8133#issuecomment-2514042517
Thank you for your proposal. Glad to see our development procedure gets more mature over time because of effort like this. +1 for the idea overall. Additionally, as Gluten is now still under comparatively earlier stage of its lifetime[1], I'll also suggest we slow down a little bit on making something like GPIP a hard restriction of large contribution. I wonder contributor may hesitate on contributing critical features because of the workload of writing a comprehensive proposal. While filing a good document before conducting contribution could be highly encouraged and appreciated. My key point is that we as a community may lower our posture a bit and thank for all kinds of contributions anyway. It doesn't mean lowering the bar of code review at all, since committers must take responsibility to keep the code healthy. I am just thinking if it's more feasible to let contributors make their own decisions on whether to provide a GPIP or brief information before opening a feature PR. Indeed, providing more information will help a lot on pushing the PR to merge since the reviewers could be clearer on the overall design and purpose of the change. So at the moment I am thinking if we can remove or rephrase the following words (or similar words from other places)? > When in doubt, if a committer thinks a change needs a GPIP, it does. Thanks. [1] Per my personal perspective. Say Velox is still under incubation either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
