PHILO-HE commented on code in PR #8133: URL: https://github.com/apache/incubator-gluten/pull/8133#discussion_r1867551042
########## docs/developers/improvement-proposals.md: ########## @@ -0,0 +1,96 @@ +--- +layout: page +title: Gluten Project Improvement Proposals (GPIP) +nav_order: 10 +parent: Developer Overview +--- + +# Gluten Project Improvement Proposals (GPIP) + +The purpose of a GPIP is to inform and involve the user community in major improvements to the Gluten codebase throughout the development process to increase the likelihood that user needs are met. GPIPs should be used for significant user-facing or cross-cutting changes, not small incremental improvements. + +If your proposal meets the definition of GPIP, we recommend you to create a GPIP, which will facilitate the advancement and discussion of the proposal, but it is not mandatory, and we welcome any contribute and community participation. + +## What is a GPIP? + +An GPIP is similar to a product requirement document commonly used in product management. + +An GPIP: Review Comment: ditto. Please check all other places. ########## docs/developers/improvement-proposals.md: ########## @@ -0,0 +1,98 @@ +--- +layout: page +title: Gluten Project Improvement Proposals (GPIP) +nav_order: 10 +parent: Developer Overview +--- + +# Gluten Project Improvement Proposals (GPIP) + +The Gluten Project Improvement Proposals doc references [the Spark SPIP documentation](https://spark.apache.org/improvement-proposals.html). + +The purpose of a GPIP is to inform and involve the user community in major improvements to the Gluten codebase throughout the development process to increase the likelihood that user needs are met. GPIPs should be used for significant user-facing or cross-cutting changes, not small incremental improvements. Review Comment: Nit. Please break this one line of statements into multiple lines, which is friendly to reading. Please also check other places. ########## docs/developers/improvement-proposals.md: ########## @@ -0,0 +1,96 @@ +--- +layout: page +title: Gluten Project Improvement Proposals (GPIP) +nav_order: 10 +parent: Developer Overview +--- + +# Gluten Project Improvement Proposals (GPIP) + +The purpose of a GPIP is to inform and involve the user community in major improvements to the Gluten codebase throughout the development process to increase the likelihood that user needs are met. GPIPs should be used for significant user-facing or cross-cutting changes, not small incremental improvements. + +If your proposal meets the definition of GPIP, we recommend you to create a GPIP, which will facilitate the advancement and discussion of the proposal, but it is not mandatory, and we welcome any contribute and community participation. Review Comment: contribute -> contribution? ########## docs/developers/improvement-proposals.md: ########## @@ -0,0 +1,98 @@ +--- +layout: page +title: Gluten Project Improvement Proposals (GPIP) +nav_order: 10 +parent: Developer Overview +--- + +# Gluten Project Improvement Proposals (GPIP) + +The Gluten Project Improvement Proposals doc references [the Spark SPIP documentation](https://spark.apache.org/improvement-proposals.html). + +The purpose of a GPIP is to inform and involve the user community in major improvements to the Gluten codebase throughout the development process to increase the likelihood that user needs are met. GPIPs should be used for significant user-facing or cross-cutting changes, not small incremental improvements. Review Comment: what does `cross-cutting` mean? Use `cutting-edge` instead? ########## docs/developers/improvement-proposals.md: ########## @@ -0,0 +1,96 @@ +--- +layout: page +title: Gluten Project Improvement Proposals (GPIP) +nav_order: 10 +parent: Developer Overview +--- + +# Gluten Project Improvement Proposals (GPIP) + +The purpose of a GPIP is to inform and involve the user community in major improvements to the Gluten codebase throughout the development process to increase the likelihood that user needs are met. GPIPs should be used for significant user-facing or cross-cutting changes, not small incremental improvements. + +If your proposal meets the definition of GPIP, we recommend you to create a GPIP, which will facilitate the advancement and discussion of the proposal, but it is not mandatory, and we welcome any contribute and community participation. + +## What is a GPIP? + +An GPIP is similar to a product requirement document commonly used in product management. Review Comment: A GPIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
