zhztheplayer commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2544316543
@kecookier Thank you for reporting. After going through the issue and relevant code I am exploring whether we could rework Velox's CollectListAggregate / CollectSetAggregate to make them match on a Spark-side TypedImperativeAggregate. The existing function `VeloxBloomFilterAggregate` might be a good example to do this. As you see, Spark `collect_list` / `collect_set` are already TypedImperativeAggregate however since they use Java-based serialization protocol (correct me if I am wrong) so we may need to write new ones with another protocol if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
