zhztheplayer commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2557138552
@NEUpanning Thanks for the explanation, very helpful here. > However, the intermediate data type for Velox's collect_list is ARRAY, which is not compatible with BINARY. That's right. I think a complete solution should involve changes to Velox code to make sure Velox's collect functions use binary intermediate buffer. Which is reasonable given that Velox could align its Spark functions more precisely with vanilla Spark. Perhaps using binary buffer is faster as well? At least in the fallback cases. `velox_collect_set` is now slow when the resident aggregate operator fell back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
