zhli1142015 commented on code in PR #8320:
URL: https://github.com/apache/incubator-gluten/pull/8320#discussion_r1896689352
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -690,6 +690,33 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
GenericExpressionTransformer(substraitExprName, children, expr)
}
+ /** Generate an expression transformer to transform JsonToStructs to
Substrait. */
+ override def genFromJsonTransformer(
+ substraitExprName: String,
+ children: Seq[ExpressionTransformer],
+ expr: JsonToStructs): ExpressionTransformer = {
+ if (!GlutenConfig.getConf.enableVeloxFromJsonFunction) {
+ throw new GlutenNotSupportException("'from_json' is not supported in
Velox")
+ }
+ if (!SparkShimLoader.getSparkShims.fromJsonSupportPartialResults) {
Review Comment:
> So will it not be offloaded to velox for spark version < 3.4 ?
Yes, as in Velox we only implement the code path of "enablePartialResults"
now.
> Are there some cases where we can still offload if this is false for lower
versions?
You can change `fromJsonSupportPartialResults` to true and run test suites
"GlutenJsonExpressionsSuite" and "GlutenJsonFunctionsSuite".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
