PHILO-HE commented on code in PR #8320:
URL: https://github.com/apache/incubator-gluten/pull/8320#discussion_r1897064139
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -2250,4 +2252,11 @@ object GlutenConfig {
.doc("If enabled, gluten will convert the viewfs path to hdfs path in
scala side")
.booleanConf
.createWithDefault(false)
+
+ val VELOX_FROM_JSON_FUNC_ENABLED =
+ buildConf("spark.gluten.sql.velox.fromJson.enabled")
+ .internal()
+ .doc("When true, offload from_json function to Velox.")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
The existing `spark.gluten.expression.blacklist` can be used to disable some
functions. Seems no need to introduce a dedicated one.
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxJsonFunctionsSuite.scala:
##########
Review Comment:
Suggest to name it like `JsonFunctionsValidateSuite.scala` for consistency.
The purpose is for validating the offloading behavior by using some simple
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
