yikf commented on code in PR #8386:
URL: https://github.com/apache/incubator-gluten/pull/8386#discussion_r1900506375
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -517,12 +517,8 @@ std::shared_ptr<connector::hive::LocationHandle>
makeLocationHandle(
const std::optional<std::string>& writeDirectory = std::nullopt,
const connector::hive::LocationHandle::TableType& tableType =
connector::hive::LocationHandle::TableType::kExisting) {
- std::string targetFileName = "";
- if (fileFormat == dwio::common::FileFormat::PARQUET) {
- targetFileName = fmt::format("gluten-part-{}{}{}", makeUuid(),
compressionFileNameSuffix(compression), ".parquet");
- }
return std::make_shared<connector::hive::LocationHandle>(
- targetDirectory, writeDirectory.value_or(targetDirectory), tableType,
targetFileName);
Review Comment:
Thank you for your suggestion.
For non-bucket tables, we can maintain the previous approach.
For bucket tables, it seems that the bucketId can only be calculated during
the write process, thereby determining the final file name, [which is
controlled by
Velox](https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/HiveDataSink.cpp#L921).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
