JkSelf commented on code in PR #8386:
URL: https://github.com/apache/incubator-gluten/pull/8386#discussion_r1904916370
##########
backends-velox/src/test/scala/org/apache/spark/sql/execution/VeloxParquetWriteSuite.scala:
##########
@@ -93,7 +93,6 @@ class VeloxParquetWriteSuite extends
VeloxWholeStageTransformerSuite {
parquetFiles.forall {
file =>
val path = new Path(f.getCanonicalPath, file)
- assert(file.endsWith(getParquetFileExtension(codec)))
Review Comment:
Why remove this check?
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -337,10 +338,14 @@ object VeloxBackendSettings extends BackendSettingsApi {
}
def validateBucketSpec(): Option[String] = {
- if (bucketSpec.nonEmpty) {
- Some("Unsupported native write: bucket write is not supported.")
- } else {
+ val isHiveCompatibleBucketTable = bucketSpec.nonEmpty && options
+ .getOrElse("__hive_compatible_bucketed_table_insertion__", "false")
+ .equals("true")
+ // Support hive compatible bucket and partition table.
+ if (bucketSpec.isEmpty || (isHiveCompatibleBucketTable &&
isPartitionedTable)) {
Review Comment:
@yikf Can you add some comments here? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
