jackylee-ch commented on code in PR #8422:
URL: https://github.com/apache/incubator-gluten/pull/8422#discussion_r1906247242
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala:
##########
@@ -103,6 +104,7 @@ object VeloxRuleApi {
.getExtendedColumnarPostRules()
.foreach(each => injector.injectPost(c => each(c.session)))
injector.injectPost(c => ColumnarCollapseTransformStages(c.glutenConf))
+ injector.injectPost(c => GlutenNoopWriterRule(c.session))
Review Comment:
It should be used for all Spark version. For Spark 3.4.0 and later, the
current gluten would add a `ColumnarToRow` after v2 commands while writing to
noop, which is not expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
