JkSelf commented on code in PR #8422:
URL: https://github.com/apache/incubator-gluten/pull/8422#discussion_r1906615593
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala:
##########
@@ -103,6 +104,7 @@ object VeloxRuleApi {
.getExtendedColumnarPostRules()
.foreach(each => injector.injectPost(c => each(c.session)))
injector.injectPost(c => ColumnarCollapseTransformStages(c.glutenConf))
+ injector.injectPost(c => GlutenNoopWriterRule(c.session))
Review Comment:
@jackylee-ch I'm sorry, I might be missing some background information.
Could you please explain why the ColumnarToRow transformation was added,
perhaps with a simple example? Additionally, could you include a description in
this PR to make it easier for others to review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
