acvictor commented on PR #8530: URL: https://github.com/apache/incubator-gluten/pull/8530#issuecomment-2590469071
> > thanks @acvictor for the fix, LGTM, can we know why before we pin cmake version to `3.28.3` instead latest cmake version or 3.30.1 ? @zhztheplayer @zhouyuan ? > > This was the commit that added it #5842 The older vcpkg releases have this version of cmake https://github.com/microsoft/vcpkg/blob/2024.01.12/scripts/vcpkgTools.xml#32 so the manual overwrite must have been required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
