acvictor commented on PR #8530: URL: https://github.com/apache/incubator-gluten/pull/8530#issuecomment-2591635582
> > thanks @acvictor for the fix, LGTM, can we know why before we pin cmake version to `3.28.3` instead latest cmake version or 3.30.1 ? @zhztheplayer @zhouyuan ? > > Hi @acvictor @gaoyangxiaozhu > > The idea is we are trying to align with Velox requirements for CMake: https://github.com/facebookincubator/velox/blob/main/CMakeLists.txt#L14 > > For VCPKG gluten is stick to use the old release `2023.10.19` and we only overwrite necessary components with newer release. The issue is several components need to be patched if we bump to recent release https://github.com/apache/incubator-gluten/blob/main/dev/vcpkg/init.sh#L56 What needs to be patched? I was building with vcpkg master branch and saw no issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
