GitHub user zhztheplayer edited a comment on the discussion: Infra: Remove the approval restriction of merging PRs
Thanks and I totally understand your view. Others must have similar concerns. > I understand that although the Spark community does not have a strict rule > requiring approval before merging code, not everyone who submits code can > merge it directly. It usually requires a senior committer to review the code > and +1 before it can be merged. Spark has enough reviewers for most code modules of its repository. It has plenty of users, contributors, organizations that support the project, as well as formal committers. Because of this, PRs can get reviewed no matter there is a rule to force that. If you look at the smaller communities that are not far beyond Gluten's volume, e.g., Zookeeper, Calcite, Tomcat, etc., there are a lot of PRs merged with approvals, and the projects are still maintaining good code / community health. If you look at [ASF's committer invitation template](https://community.apache.org/templates/committer-invite.txt), you could find the words "We like to work on trust rather than unnecessary constraints". This is also the [meritocracy]https://www.apache.org/foundation/how-it-works/#meritocracy the ASF praises highly. It doesn't mean a committer can do anything they want, a committer should do best to make the best decisions. If they think their PR needs to be reviewed, then they will send a review reques t to others. We should trust our committers on they have the capability to make the good action. I know the community is used to the currently rule so some may be surprised if we made the change. I'd say give the community some time to see what happens, since we didn't try with the other way since the project entered incubation. If after some time (say, several weeks), we find the new rule doesn't work as expected, we can add the rule back and the whole action should not be harmful. GitHub link: https://github.com/apache/incubator-gluten/discussions/8556#discussioncomment-11863631 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
