GitHub user zhouyuan added a comment to the discussion: Infra: Remove the approval restriction of merging PRs
I was hoping to keep this restriction. Not everyone is as senior as @zhztheplayer and they may make mistakes sometimes. Through code reviews, we can achieve two key objectives: - Basic Code Quality Control: Ensuring that the code meets our quality standards. - Onboarding and Knowledge Sharing: Helping team members familiarize themselves with other components (e.g., RAS). These are the two critical growth factors currently missing for Gluten IMO. Once we establish a process for thorough and effective reviews, every patch will benefit from meaningful feedback. I guess your ask is to fast merge on some patches(e.g. big refactors, which may easily get conflict), we could setup a new mechanism: e.g., with a new special label for such PRs BTW The branch protection(required review) feature is added on 2020 so this maybe one reason why some old projects did not include this: https://infra.apache.org/blog/even-more-github-features-added.html Thanks, -yuan GitHub link: https://github.com/apache/incubator-gluten/discussions/8556#discussioncomment-11864699 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
