PHILO-HE commented on code in PR #8586:
URL: https://github.com/apache/incubator-gluten/pull/8586#discussion_r1924848067
##########
backends-clickhouse/src-celeborn/main/scala/org/apache/spark/shuffle/CHCelebornColumnarShuffleWriter.scala:
##########
@@ -80,10 +79,10 @@ class CHCelebornColumnarShuffleWriter[K, V](
nativeBufferSize,
capitalizedCompressionCodec,
compressionLevel,
- GlutenConfig.get.chColumnarShuffleSpillThreshold,
Review Comment:
Can we keep the use of `GlutenConfig.get` after the refactor? I prefer a
uniform API. It requires either velox conf or CH conf to be covered by
GlutenConfig at runtime somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
