zhztheplayer commented on code in PR #8586:
URL: https://github.com/apache/incubator-gluten/pull/8586#discussion_r1925157558
##########
backends-clickhouse/src-celeborn/main/scala/org/apache/spark/shuffle/CHCelebornColumnarShuffleWriter.scala:
##########
@@ -80,10 +79,10 @@ class CHCelebornColumnarShuffleWriter[K, V](
nativeBufferSize,
capitalizedCompressionCodec,
compressionLevel,
- GlutenConfig.get.chColumnarShuffleSpillThreshold,
Review Comment:
Perhaps we can make `VeloxConfig` inherit from `GlutenConfig`? Then
`VeloxConfig` can be used uniformly in Velox backend for both Velox / Common
configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
