WangGuangxin commented on code in PR #8669:
URL: https://github.com/apache/incubator-gluten/pull/8669#discussion_r1961002473
##########
gluten-arrow/src/main/java/org/apache/gluten/vectorized/ArrowColumnarRow.java:
##########
@@ -227,36 +226,7 @@ public Object get(int ordinal, DataType dataType) {
@Override
public void update(int ordinal, Object value) {
- if (value == null) {
- setNullAt(ordinal);
- } else {
- DataType dt = columns[ordinal].dataType();
- if (dt instanceof BooleanType) {
- setBoolean(ordinal, (boolean) value);
- } else if (dt instanceof IntegerType) {
- setInt(ordinal, (int) value);
- } else if (dt instanceof ShortType) {
- setShort(ordinal, (short) value);
- } else if (dt instanceof LongType) {
- setLong(ordinal, (long) value);
- } else if (dt instanceof FloatType) {
- setFloat(ordinal, (float) value);
- } else if (dt instanceof DoubleType) {
- setDouble(ordinal, (double) value);
- } else if (dt instanceof DecimalType) {
- DecimalType t = (DecimalType) dt;
- Decimal d = Decimal.apply((BigDecimal) value, t.precision(),
t.scale());
- setDecimal(ordinal, d, t.precision());
- } else if (dt instanceof CalendarIntervalType) {
- setInterval(ordinal, (CalendarInterval) value);
- } else if (dt instanceof StringType) {
- setUTF8String(ordinal, (UTF8String) value);
- } else if (dt instanceof BinaryType) {
- setBinary(ordinal, (byte[]) value);
- } else {
- throw new UnsupportedOperationException("Datatype not supported " +
dt);
- }
- }
+ throw new UnsupportedOperationException();
Review Comment:
add back this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
