WangGuangxin commented on code in PR #8669: URL: https://github.com/apache/incubator-gluten/pull/8669#discussion_r1961451338
########## backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala: ########## @@ -59,10 +59,8 @@ case class ColumnarPartialProjectExec(original: ProjectExec, child: SparkPlan)( private val projectAttributes: ListBuffer[Attribute] = ListBuffer() private val projectIndexInChild: ListBuffer[Int] = ListBuffer() private var UDFAttrNotExists = false - private var hasUnsupportedDataType = replacedAliasUdf.exists(a => !validateDataType(a.dataType)) Review Comment: The check is duplidate within `getProjectIndexInChildOutput`, so removed one cc @jinchengchenghh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
