marin-ma commented on code in PR #8835:
URL: https://github.com/apache/incubator-gluten/pull/8835#discussion_r1971944753


##########
docs/velox-backend-support-progress.md:
##########
@@ -344,25 +343,25 @@ Gluten supports 199 functions. (Drag to right to see all 
data types)
 | date_from_unix_date          |                        |                      
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | date_part                    |                        |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | date_sub                     |                        |                      
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| date_trunc                   | date_trunc             |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
+| date_trunc                   | date_trunc             | date_trunc           
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | datediff                     | date_diff              |                      
 | S      |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
 | day                          | day                    |                      
 | S      |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
 | dayofmonth                   | day_of_month           |                      
 | S      |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
 | dayofweek                    | day_of_week,dow        |                      
 | S      |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
 | dayofyear                    | day_of_year,doy        |                      
 | S      |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
-| extract                      |                        |                      
 |        |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
+| extract                      | extract                | extract              
 | S      |                          |         |      |       |     |      |    
   |        | S    | S         |        |         |      |        |          |  
     |     |        |     |
 | from_unixtime                | from_unixtime          |                      
 | S      |                          |         |      |       |     | S    |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | from_utc_timestamp           |                        | from_utc_timestamp   
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | hour                         | hour                   |                      
 | S      |                          |         |      |       |     |      |    
   |        |      | S         |        |         |      |        |          |  
     |     |        |     |
 | last_day                     |                        | last_day             
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | make_date                    |                        | make_date            
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | make_dt_interval             |                        |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| make_interval                |                        |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| make_timestamp               |                        |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| make_ym_interval             |                        |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
+| make_interval                | make_interval          | make_interval        
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |

Review Comment:
   The return type for "make_interval" is `CalendarIntervalType`, which is not 
supported yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to