marin-ma commented on code in PR #8835:
URL: https://github.com/apache/incubator-gluten/pull/8835#discussion_r1971937263


##########
docs/velox-backend-support-progress.md:
##########
@@ -299,20 +299,19 @@ Gluten supports 199 functions. (Drag to right to see all 
data types)
 | array_remove                 | array_remove           |                      
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
 | array_repeat                 |                        |                      
 | S      |                          | S       | S    | S     | S   | S    | S  
   | S      | S    | S         | S      | S       |      |        |          |  
     |     |        |     |
 | array_sort                   | array_sort             | array_sort           
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| array_union                  |                        |                      
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
-| arrays_overlap               | array_overlap          | S                    
 |        |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |
+| array_union                  | array_union            | array_union          
 | S      |                          |         |      |       |     |      |    
   |        |      |           |        |         |      |        |          |  
     |     |        |     |

Review Comment:
   There are fallback logs
   ```
   12:35:13.302 WARN org.apache.spark.sql.execution.GlutenFallbackReporter: 
Validation failed for plan: Project[QueryId=133], due to: 
    - Native validation failed: 
      |- Validation failed due to exception caught at 
file:SubstraitToVeloxPlanValidator.cc line:1368 function:validate, thrown from 
file:ExprCompiler.cpp line:475 function:compileRewrittenExpression, 
reason:Scalar function name not registered: array_union, called with arguments: 
(ARRAY<DOUBLE>, ARRAY<DOUBLE>).
   ```
   Seems like `array_union` is not supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to