KevinyhZou commented on code in PR #9179:
URL: https://github.com/apache/incubator-gluten/pull/9179#discussion_r2022328279
##########
cpp-ch/local-engine/Functions/SparkParseURL.cpp:
##########
@@ -380,6 +380,21 @@ struct SparkExtractURLHost
if (userinfo_delim_pos && userinfo_delim_pos < end)
Review Comment:
The implementation of `SparkParseURL.cpp` is seems try to use the url
parsing function of clickhouse, and I think it is may be better than
`Poco::URI`, if `Poco::URI` is a better way, I think ch would use it by default
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
