taiyang-li commented on code in PR #9179:
URL: https://github.com/apache/incubator-gluten/pull/9179#discussion_r2022340501
##########
cpp-ch/local-engine/Functions/SparkParseURL.cpp:
##########
@@ -380,6 +380,21 @@ struct SparkExtractURLHost
if (userinfo_delim_pos && userinfo_delim_pos < end)
Review Comment:
But the existing code looks a bit messy and will be difficult to maintain in
the future. Would you mind investigating the feasibility of Poco::URI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
