PHILO-HE commented on code in PR #9207:
URL: https://github.com/apache/incubator-gluten/pull/9207#discussion_r2026537185
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -48,14 +48,29 @@ function yum_install {
function wget_and_untar {
Review Comment:
@yaooqinn, thanks for work!
I note upstream velox's wget_and_untar has a check for dir to let user
decide whether to re-download the tar. Does it meet our needs?
Actually, by removing this `wget_and_untar` function, Velox's
`wget_and_untar` (placed in `setup-helper-functions.sh`) will be used in this
script. I am wondering whether this improvement can be put in upstream velox.
Then, both `setup-centos7.sh` and `setup-centos8.sh` (maintained in Gluten) can
use that, as well as `setup-centos9.sh` and `setup-ubuntu.sh` (maintained in
Velox).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
