yaooqinn commented on code in PR #9207:
URL: https://github.com/apache/incubator-gluten/pull/9207#discussion_r2030360608
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -48,14 +48,29 @@ function yum_install {
function wget_and_untar {
Review Comment:
Hi, @PHILO-HE. Thanks for the suggestion.
I had considered using velox's wget_and_untar, but I didn't apply it here.
- Some of the dependency names might conflict as these names are in the form
of `vx.y.z`.
- velox's wget_and_untar does not check whether the tar ball is valid or not.
> I am wondering whether this improvement can be put in upstream velox.
This is a good suggestion, I will try to send a PR to the upstream. But how
about we focus the dependency management here first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
