zhztheplayer commented on code in PR #9275:
URL: https://github.com/apache/incubator-gluten/pull/9275#discussion_r2034991209
##########
cpp-ch/local-engine/local_engine_jni.cpp:
##########
@@ -166,11 +166,6 @@ JNIEXPORT jint JNI_OnLoad(JavaVM * vm, void * /*reserved*/)
return JNI_VERSION_1_8;
}
-JNIEXPORT void JNI_OnUnload(JavaVM * vm, void * /*reserved*/)
-{
- // manually destroy native in 'nativeDestroyNative' method
-}
Review Comment:
IIUC, in CH, the unloading actually does nothing?
Then why was the unloading code from Java side strictly required for CH
backend in current code base?
https://github.com/apache/incubator-gluten/blob/fdd83714067c4a77006d6695b2bd8f6ad9e3ef23/backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHListenerApi.scala#L84-L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
