baibaichen commented on code in PR #9275:
URL: https://github.com/apache/incubator-gluten/pull/9275#discussion_r2035067204
##########
cpp-ch/local-engine/local_engine_jni.cpp:
##########
@@ -166,11 +166,6 @@ JNIEXPORT jint JNI_OnLoad(JavaVM * vm, void * /*reserved*/)
return JNI_VERSION_1_8;
}
-JNIEXPORT void JNI_OnUnload(JavaVM * vm, void * /*reserved*/)
-{
- // manually destroy native in 'nativeDestroyNative' method
-}
Review Comment:
No, we actually need unloading. We curently move to
`Java_org_apache_gluten_vectorized_ExpressionEvaluatorJniWrapper_nativeDestroyNative`
see https://github.com/apache/incubator-gluten/pull/9242
The reason why we do this is
https://github.com/openjdk/jdk17u-dev/commit/75a8b7fa831ec22a149f271c119a2496c1c5ee87
doesn't allow unload jni for built-in classloader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
