wForget commented on code in PR #9325: URL: https://github.com/apache/incubator-gluten/pull/9325#discussion_r2044115265
########## cpp/velox/substrait/SubstraitToVeloxPlan.cc: ########## @@ -1292,18 +1292,20 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait:: // Velox requires Filter Pushdown must being enabled. bool filterPushdownEnabled = true; + auto names = colNameList; Review Comment: Since we map by filed name instead of indices, this change is acceptable. https://github.com/apache/incubator-gluten/blob/e8b723791086fd520e1c97f6da4f969783da2215/cpp/velox/compute/VeloxBackend.cc#L313-L315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
