wForget commented on code in PR #9325:
URL: https://github.com/apache/incubator-gluten/pull/9325#discussion_r2043809306


##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -1292,18 +1292,20 @@ core::PlanNodePtr 
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
 
   // Velox requires Filter Pushdown must being enabled.
   bool filterPushdownEnabled = true;
+  auto names = colNameList;

Review Comment:
   `readRel.base_schema` are output schema and are not consistent with parquet 
file schema, so it seems that `readRel.base_schema` cannot be set as hive 
fileSchema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to