zhouyuan commented on code in PR #9341:
URL: https://github.com/apache/incubator-gluten/pull/9341#discussion_r2047094790
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -135,6 +135,37 @@ private[gluten] class GlutenDriverPlugin extends
DriverPlugin with Logging {
}
}
+ private def checkOffHeapSettings(conf: SparkConf): Unit = {
+ if (
+ conf.getBoolean(
+ DYNAMIC_OFFHEAP_SIZING_ENABLED.key,
+ DYNAMIC_OFFHEAP_SIZING_ENABLED.defaultValue.get)
+ ) {
+ // When dynamic off-heap sizing is enabled, off-heap mode is not
strictly required to be
+ // enabled. Skip the check.
+ return
+ }
+
+ if (
+ conf.getBoolean(COLUMNAR_MEMORY_UNTRACKED.key,
COLUMNAR_MEMORY_UNTRACKED.defaultValue.get)
Review Comment:
looking at the logic, if `DYNAMIC_OFFHEAP_SIZING_ENABLED=false`, and
`COLUMNAR_MEMORY_UNTRACKED=true` then it will also skip the check of off-heap
settings, is this inteded?
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -1241,6 +1243,16 @@ object GlutenConfig {
.booleanConf
.createWithDefault(false)
+ val COLUMNAR_MEMORY_UNTRACKED =
+ buildConf("spark.gluten.memory.untracked")
+ .internal()
+ .doc(
+ "When enabled, turn all native memory allocations in Gluten into
untracked. Spark " +
Review Comment:
based on the description, this feature should be effect only with
`DYNAMIC_OFFHEAP_SIZING_ENABLED` case? or do you intend to introduce this
feature in case with static off-heap also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
