zhztheplayer commented on code in PR #9341:
URL: https://github.com/apache/incubator-gluten/pull/9341#discussion_r2047153954
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -135,6 +135,37 @@ private[gluten] class GlutenDriverPlugin extends
DriverPlugin with Logging {
}
}
+ private def checkOffHeapSettings(conf: SparkConf): Unit = {
+ if (
+ conf.getBoolean(
+ DYNAMIC_OFFHEAP_SIZING_ENABLED.key,
+ DYNAMIC_OFFHEAP_SIZING_ENABLED.defaultValue.get)
+ ) {
+ // When dynamic off-heap sizing is enabled, off-heap mode is not
strictly required to be
+ // enabled. Skip the check.
+ return
+ }
+
+ if (
+ conf.getBoolean(COLUMNAR_MEMORY_UNTRACKED.key,
COLUMNAR_MEMORY_UNTRACKED.defaultValue.get)
Review Comment:
Yes, as mentioned in the other comment, it's allowed for user to set
```
spark.memory.offHeap.enabled=false
spark.gluten.memory.untracked=true
```
at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
