Surbhi-Vijay commented on code in PR #9385:
URL: https://github.com/apache/incubator-gluten/pull/9385#discussion_r2059635416
##########
backends-velox/src/main/scala/org/apache/spark/api/python/ColumnarArrowEvalPythonExec.scala:
##########
@@ -211,12 +212,27 @@ case class ColumnarArrowEvalPythonExec(
child: SparkPlan,
evalType: Int)
extends EvalPythonExec
- with GlutenPlan {
+ with GlutenPlan
+ with ValidatablePlan {
override def batchType(): Convention.BatchType = ArrowJavaBatch
override def rowType0(): Convention.RowType = Convention.RowType.None
+ override protected def doValidateInternal(): ValidationResult = {
+ val (_, inputs) = udfs.map(collectFunctions).unzip
+ inputs.map {
+ input =>
+ input.map {
+ e =>
+ if (!e.isInstanceOf[AttributeReference]) {
Review Comment:
Removed the check and verified that all pyspark testcases are passing in
internal setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
