Surbhi-Vijay commented on code in PR #9385:
URL: https://github.com/apache/incubator-gluten/pull/9385#discussion_r2059979932
##########
backends-velox/src/main/scala/org/apache/spark/api/python/ColumnarArrowEvalPythonExec.scala:
##########
@@ -211,12 +211,28 @@ case class ColumnarArrowEvalPythonExec(
child: SparkPlan,
evalType: Int)
extends EvalPythonExec
- with GlutenPlan {
+ with ValidatablePlan {
override def batchType(): Convention.BatchType = ArrowJavaBatch
override def rowType0(): Convention.RowType = Convention.RowType.None
+ override protected def doValidateInternal(): ValidationResult = {
+ val (_, inputs) = udfs.map(collectFunctions).unzip
+ inputs.foreach {
+ input =>
+ input.foreach {
+ case e: AttributeReference if e.exprId != null =>
Review Comment:
Got confused previously, added the condition now in doValidateInternal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
