Yohahaha commented on code in PR #9498:
URL: https://github.com/apache/incubator-gluten/pull/9498#discussion_r2074588823
##########
cpp/velox/compute/VeloxRuntime.cc:
##########
@@ -189,6 +189,8 @@ std::shared_ptr<ResultIterator>
VeloxRuntime::createResultIterator(
VeloxPlanConverter veloxPlanConverter(
inputs, memoryManager()->getLeafMemoryPool().get(), sessionConf,
*localWriteFilesTempPath());
veloxPlan_ = veloxPlanConverter.toVeloxPlan(substraitPlan_,
std::move(localFiles_));
+ LOG_IF(INFO, debugModeEnabled_) << std::string(50, '#') << " received velox
plan: " << taskInfo_ << std::endl
Review Comment:
> ultra nit: can we move the 50 to constant and rename the other usage here
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
