jinchengchenghh commented on code in PR #9498:
URL: https://github.com/apache/incubator-gluten/pull/9498#discussion_r2075017886
##########
cpp/velox/compute/VeloxRuntime.cc:
##########
@@ -189,6 +189,8 @@ std::shared_ptr<ResultIterator>
VeloxRuntime::createResultIterator(
VeloxPlanConverter veloxPlanConverter(
inputs, memoryManager()->getLeafMemoryPool().get(), sessionConf,
*localWriteFilesTempPath());
veloxPlan_ = veloxPlanConverter.toVeloxPlan(substraitPlan_,
std::move(localFiles_));
+ LOG_IF(INFO, debugModeEnabled_) << std::string(50, '#') << " received velox
plan: " << taskInfo_ << std::endl
Review Comment:
> can we print as DEBUG?
When I change from INFO to DEBUG, I receive the exception
```
[1928](https://github.com/apache/incubator-gluten/actions/runs/14855309331/job/41707123590#step:4:1929)
/work/cpp/velox/compute/VeloxRuntime.cc:162:3: error:
'COMPACT_GOOGLE_LOG_DEBUG' was not declared in this scope; did you mean
'COMPACT_GOOGLE_LOG_ERROR'?
[1929](https://github.com/apache/incubator-gluten/actions/runs/14855309331/job/41707123590#step:4:1930)
162 | LOG_IF(DEBUG, debugModeEnabled_) << "############### received
velox plan: " << taskInfo_ << std::endl
```
The `debugModeEnabled_ ` controls it only take effect in debug mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
