PHILO-HE commented on code in PR #9759:
URL: https://github.com/apache/incubator-gluten/pull/9759#discussion_r2115366707
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -146,6 +147,7 @@ class VeloxListenerApi extends ListenerApi with Logging {
SparkDirectoryUtil.init(conf)
initialize(conf, isDriver = false)
+ addIfNeedMemoryDumpShutdownHook(conf)
}
override def onExecutorShutdown(): Unit = shutdown()
Review Comment:
Curious whether we can add the dump in `onExecutorShutdown`. If it's also
workable, I am not sure which is better. Seems they are equivalent, but placing
it here is clearer? cc @zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
