wForget commented on code in PR #9759:
URL: https://github.com/apache/incubator-gluten/pull/9759#discussion_r2115607586
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -146,6 +147,7 @@ class VeloxListenerApi extends ListenerApi with Logging {
SparkDirectoryUtil.init(conf)
initialize(conf, isDriver = false)
+ addIfNeedMemoryDumpShutdownHook(conf)
}
override def onExecutorShutdown(): Unit = shutdown()
Review Comment:
Putting it in onExecutorShutdown can also be triggered by the shutdown hook,
but it will require that the previous methods are executed successfully.
https://github.com/apache/spark/blob/6a89f654bb54de73f20f07c10ca6f7ff186bbeb6/core/src/main/scala/org/apache/spark/executor/Executor.scala#L93-L95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
