PHILO-HE commented on code in PR #9864:
URL: https://github.com/apache/incubator-gluten/pull/9864#discussion_r2127734625
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -234,13 +239,15 @@ function setup_linux {
fi
}
-if [ $OS == 'Linux' ]; then
- setup_linux
-elif [ $OS == 'Darwin' ]; then
- :
-else
- echo "Unsupported kernel: $OS"
- exit 1
+if [[ "$RUN_SETUP_SCRIPT" == "ON" ]]; then
+ if [ $OS == 'Linux' ]; then
+ setup_linux
Review Comment:
Actually, the setup for dependencies and tools will be done from this line:
https://github.com/apache/incubator-gluten/blob/9419b59b3f9a14c784e5fd76b3f0442c0f9c6b7a/dev/builddeps-veloxbe.sh#L281
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -234,13 +239,15 @@ function setup_linux {
fi
}
-if [ $OS == 'Linux' ]; then
- setup_linux
-elif [ $OS == 'Darwin' ]; then
- :
-else
- echo "Unsupported kernel: $OS"
- exit 1
+if [[ "$RUN_SETUP_SCRIPT" == "ON" ]]; then
+ if [ $OS == 'Linux' ]; then
+ setup_linux
Review Comment:
Please note the so-called setup here is not actually running setup script,
but just applying some changes on the script. I am afraid the following changes
you made may not serve your purpose.
```
if [[ -n $RUN_SETUP_SCRIPT ]]; then
VELOX_PARAMETER+="--run_setup_script=$RUN_SETUP_SCRIPT "
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
