yaooqinn commented on PR #9864: URL: https://github.com/apache/incubator-gluten/pull/9864#issuecomment-2942493847
Hi @PHILO-HE, thank you for the suggestions. However, for the comment here: > I may understand this pr now. Could you rename setup_linux to prepare_setup_linux in get_velox.sh? It's easily misleading. I don't think these two names reduce any ambiguity but actually increase recognition bar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
