FelixYBW commented on code in PR #9869:
URL: https://github.com/apache/incubator-gluten/pull/9869#discussion_r2131460823
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -144,10 +144,14 @@ class InternalMemoryManager : public MemoryManager {
public:
InternalMemoryManager(const std::string& kind) : MemoryManager(kind) {}
- arrow::MemoryPool* getArrowMemoryPool() override {
+ arrow::MemoryPool* defaultArrowMemoryPool() override {
throw GlutenException("Not implemented");
}
+ std::shared_ptr<arrow::MemoryPool> addArrowMemoryPool(const std::string&
name) override {
Review Comment:
rename it as createArrowMemoryPool since it's make_shared in the function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
